packages/webpack/template-webpack-plugin/etc/template-webpack-plugin.api.md (1)

19-24: No direct edit needed in generated API report.

This warning is a downstream artifact from packages/webpack/template-webpack-plugin/src/index.ts; fixing the source declaration is the right path.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/webpack/template-webpack-plugin/etc/template-webpack-plugin.api.md`
around lines 19 - 24, The API report flags CSSPlugins as missing a release tag;
update the source export for CSSPlugins in the module where it's declared by
adding a JSDoc release tag (e.g., /** `@public` */) above the export so the
generated declaration includes the tag, and ensure the related Plugins type used
in the CSSPlugins.parserPlugins typing is correctly exported/imported (symbols:
CSSPlugins, Plugins) so the API extractor can resolve types.

packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts (1)

118-153: Prefer mutating the reducer accumulator to avoid repeated object cloning.

Line 118-Line 153 rebuilds prev with object spread on every asset. This creates avoidable O(n²)-style allocation churn for larger builds.

♻️ Suggested refactor

- const customSections = assets
-   .reduce<Record<string, { content: string | { ruleList: LynxStyleNode[] } }>>(
-     (prev, cur) => {
-       switch (cur.info['assetType']) {
-         case 'javascript':
-           return ({
-             ...prev,
-             [cur.name.replace(/\.js$/, '')]: {
-               content: cur.source.source().toString(),
-             },
-           })
-         case 'extract-css':
-           return ({
-             ...prev,
-             [`${cur.name.replace(/\.css$/, '')}:CSS`]: {
-               'encoding': 'CSS',
-               content: {
-                 ruleList: cssChunksToMap(
-                   [cur.source.source().toString()],
-                   [],
-                   true,
-                 ).cssMap[0] ?? [],
-               },
-             },
-           })
-         default:
-           return prev
-       }
-     },
-     {},
-   )
+ const customSections: Record<string, { content: string | { ruleList: LynxStyleNode[] } }> = {}
+ for (const cur of assets) {
+   switch (cur.info['assetType']) {
+     case 'javascript':
+       customSections[cur.name.replace(/\.js$/, '')] = {
+         content: cur.source.source().toString(),
+       }
+       break
+     case 'extract-css':
+       customSections[`${cur.name.replace(/\.css$/, '')}:CSS`] = {
+         encoding: 'CSS',
+         content: {
+           ruleList: cssChunksToMap([cur.source.source().toString()], [], true).cssMap[0] ?? [],
+         },
+       } as never
+       break
+     default:
+       break
+   }
+ }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@packages/rspeedy/lynx-bundle-rslib-config/src/webpack/ExternalBundleWebpackPlugin.ts`
around lines 118 - 153, The reducer currently rebuilds the accumulator with
object spread on each iteration causing O(n²) allocations; in the reduce
callback (the function passed to .reduce in ExternalBundleWebpackPlugin) stop
returning new objects and instead mutate the accumulator `prev`: for
'javascript' set prev[cur.name.replace(/\.js$/, '')] = { content:
cur.source.source().toString() } and for 'extract-css' set
prev[`${cur.name.replace(/\.css$/, '')}:CSS`] = { encoding: 'CSS', content: {
ruleList: cssChunksToMap([cur.source.source().toString()], [], true).cssMap[0]
?? [] } }; then return prev; keep the reduce generic/typing for Record<string, {
content: string | { ruleList: LynxStyleNode[] } }> unchanged.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

packages/webpack/externals-loading-webpack-plugin/src/index.ts (2)

341-341: ⚠️ Potential issue | 🟡 Minor

Harden catch-path message construction for non-Error throws.

Line 341 and Line 368 assume error.message exists; primitives/null can cause a second failure in error handling.

🛡️ Suggested fix

- reject(new Error('Failed to load script ' + sectionPath + ' in ' + response.url + ': ' + error.message, { cause: error }))
+ const reason = (error && typeof error === 'object' && 'message' in error)
+   ? String(error.message)
+   : String(error);
+ reject(new Error('Failed to load script ' + sectionPath + ' in ' + response.url + ': ' + reason, { cause: error }))

- throw new Error('Failed to load script ' + sectionPath + ' in ' + response.url + ': ' + error.message, { cause: error })
+ const reason = (error && typeof error === 'object' && 'message' in error)
+   ? String(error.message)
+   : String(error);
+ throw new Error('Failed to load script ' + sectionPath + ' in ' + response.url + ': ' + reason, { cause: error })

Also applies to: 368-368

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/webpack/externals-loading-webpack-plugin/src/index.ts` at line 341,
The catch-path builds a new Error using error.message which can throw if the
thrown value is null/primitive; replace uses of error.message in the reject(new
Error(..., { cause: error })) expression with a safe stringifier (e.g. const
safeMsg = (error && typeof error === 'object' && 'message' in error) ? (error as
Error).message : String(error)) and use safeMsg in the constructed message, and
optionally only pass cause when error is an Error instance (e.g. cause: error
instanceof Error ? error : undefined) to harden both occurrences that currently
reference error.message.

---

330-331: ⚠️ Potential issue | 🟠 Major

Use configured main-thread suffix for CSS section derivation.

Line 330 and Line 357 still hard-code __main-thread, so CSS lookup can fail when mainThreadLayer is customized.

🔧 Suggested fix

- const styleSheet = __LoadStyleSheet(sectionPath.replace('__main-thread', '') + ':CSS', response.url);
+ const mainThreadSuffix = '__${externalsLoadingPluginOptions.mainThreadLayer}';
+ const cssSectionPath = sectionPath.endsWith(mainThreadSuffix)
+   ? sectionPath.slice(0, -mainThreadSuffix.length)
+   : sectionPath;
+ const styleSheet = __LoadStyleSheet(cssSectionPath + ':CSS', response.url);

Also applies to: 357-358

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/webpack/externals-loading-webpack-plugin/src/index.ts` around lines
330 - 331, Replace the hard-coded "__main-thread" string with the configured
main-thread suffix (mainThreadLayer) when deriving the CSS section path: change
the calls that compute the CSS lookup (the sectionPath.replace('__main-thread',
'') + ':CSS' used before passing to __LoadStyleSheet) to remove the configured
mainThreadLayer instead of the literal, and apply the same change to the other
occurrence that currently uses "__main-thread"; ensure you remove only the
suffix instance of mainThreadLayer from sectionPath (preserving other parts)
before appending ":CSS" and calling __LoadStyleSheet(response.url).

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro